[Bug 499743] Review Request: jack-keyboard - Virtual keyboard for JACK MIDI
bugzilla at redhat.com
bugzilla at redhat.com
Fri May 8 05:49:53 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499743
Parag AN(पराग) <panemade at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |panemade at gmail.com
--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2009-05-08 01:49:52 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1341298
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
030a666f1703ef1ab3eae6004cb04a9a jack-keyboard-2.5.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ translations are available
+ Does owns the directories it creates.
+ Icon Cache scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Desktop file installed correctly.
Suggestions:
1) change Generic name to
GenericName=Virtual MIDI Keyboard"
2) you can add
Requires: hicolor-icon-theme
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list