[Bug 499856] Review Request: perl-WWW-Mechanize-TreeBuilder - WWW::Mechanize::TreeBuilder Perl module

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=499856


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-05-08 13:11:30 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1343426
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
0514a4a70b929361758f8a9c16705b53  WWW-Mechanize-TreeBuilder-1.10000.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=3, Tests=29,  2 wallclock secs ( 0.03 usr  0.01 sys +  1.56 cusr  0.27
csys =  1.87 CPU)
+ Package perl-WWW-Mechanize-TreeBuilder-1.10000-1.fc12.noarch =>
 Provides: perl(WWW::Mechanize::TreeBuilder) = 1.10000
 Requires: perl(Moose::Util::TypeConstraints) perl(MooseX::Role::Parameterized)

Suggestions:
1) Are you sure you need
BuildRequires:  perl >= 1:5.8.1

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.