[Bug 499137] Review Request: sipwitch - SIP telephony server for secure phone systems

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=499137





--- Comment #8 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-05-09 12:35:19 EDT ---
For -2:

* BR
  - build.log shows:
-------------------------------------------------------------
   714  DEBUG: checking gcrypt/gcrypt.h usability... no
   715  DEBUG: checking gcrypt/gcrypt.h presence... no
   716  DEBUG: checking for gcrypt/gcrypt.h... no
   717  DEBUG: checking gcrypt.h usability... no
   718  DEBUG: checking gcrypt.h presence... no
   719  DEBUG: checking for gcrypt.h... no
   720  DEBUG: checking openssl/md5.h usability... no
   721  DEBUG: checking openssl/md5.h presence... no
   722  DEBUG: checking for openssl/md5.h... no
   723  DEBUG: checking sasl/md5global.h usability... no
   724  DEBUG: checking sasl/md5global.h presence... no
   725  DEBUG: checking for sasl/md5global.h... no
-------------------------------------------------------------
    Looking at configure.in, common/digest.cpp, and utils/sipdigest.cpp,
    it seems that adding "BuildRequires: libgcrypt-devel is preferable.
    After that, build.log shows:
-------------------------------------------------------------
   722  DEBUG: checking gcrypt/gcrypt.h usability... no
   723  DEBUG: checking gcrypt/gcrypt.h presence... no
   724  DEBUG: checking for gcrypt/gcrypt.h... no
   725  DEBUG: checking gcrypt.h usability... yes
   726  DEBUG: checking gcrypt.h presence... yes
   727  DEBUG: checking for gcrypt.h... yes
   728  DEBUG: checking for gcry_control in -lgcrypt... yes
-------------------------------------------------------------

* build failure
  - -2 srpm installs sipwitch initscript under 
    %buildroot%_sysconfdir/init.d, not %buildroot%_initrddir and
    build fails there. Currently the following is needed:
-------------------------------------------------------------
%{__mkdir_p} %{buildroot}%{_initrddir}
%{__mv} -f %{buildroot}%{_sysconfdir}/init.d/* %{buildroot}%{_initrddir}
rmdir %{buildroot}%{_sysconfdir}/init.d/
-------------------------------------------------------------

* Initscripts
  - Requires(postun): initscripts is still missing.
  - "service sipwitch restart" won't work like:
-------------------------------------------------------------
# service sipwitch restart
Restarting sipwitch: /etc/init.d/sipwitch: line 116: start-stop-daemon: command
not found
-------------------------------------------------------------

* rpmlint
  - Still rpmlint complains like:
-------------------------------------------------------------
sipwitch-python-swig.i586: E: script-without-shebang
/usr/lib/python2.6/site-packages/sipwitch.py
-------------------------------------------------------------
    Please check my previous comment:
>   - If %{python_sitelib}/sipwitch.py is to be executed directly from
>     users, then this script should have 0755 permission.
>     Otherwise the shebang on this script should be removed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.