[Bug 499394] Review Request: ampache - web based audio/video streaming application

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=499394





--- Comment #5 from Paulo Roma Cavalcanti <promac at gmail.com>  2009-05-10 14:58:55 EDT ---
Thanks for you feedback.

I removed almost all the warnings/errors:

[cascavel:~] rpmlint ampache
ampache.noarch: E: non-executable-script
/var/www/ampache/locale/base/gather-messages.sh 0644
ampache.noarch: W: non-standard-uid /var/log/ampache apache
ampache.noarch: W: non-standard-gid /etc/ampache.cfg apache
ampache.noarch: E: non-readable /etc/ampache.cfg 0640
1 packages and 0 specfiles checked; 2 errors, 2 warnings.

I had a misplaced %config in the templates directory, which caused
almost all of them.

I included a logrotate file, and did some other clean ups.

Regarding your question about the themes, I put them in the package,
because I do not like ampache default theme, and they are small.
Creating another package just for the themes seems to be an unnecessary
work, and in general, people do not even know about the existence
of a theme package. I also included my favourite theme now.

Ampache does not really require these packages, but

Requires(hint): xmms lame mp3splt

was intended to add all of its functionality. But I think the hint
is not just a hint. It will force the installation of all the three packages,
and lame and mp3splt are not part of Fedora, because of licence issues.


SRPM URL: http://orion.lcg.ufrj.br/RPMS/src/ampache-3.5-7.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.