[Bug 487114] Review Request: gvrpcd - A program for announcing VLANs using GVRP.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487114


Michael Schwendt <bugs.michael at gmx.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #17 from Michael Schwendt <bugs.michael at gmx.net>  2009-05-15 04:37:16 EDT ---
Haven't found further issues.

Instead of depending on "chkconfig" and "initscripts", you can prefer a
dependency on /sbin/chkconfig and /sbin/service instead, since you execute
those tools with absolute path. The dependency on those file locations is not
more expensive than requiring the package names. The file Provides for files in
many (or all) *bin* paths as well as files in /etc are covered by the primary
metadata file. More packages do it already, too.

$ repoquery --whatrequires /sbin/chkconfig|wc -l
364
$ repoquery --whatrequires chkconfig|wc -l
202


APPROVED : gvrpcd-1.3-1.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.