[Bug 500922] Review Request: zerofree - Utility to force unused ext2 inodes and blocks to zero
bugzilla at redhat.com
bugzilla at redhat.com
Fri May 15 10:36:41 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=500922
--- Comment #6 from Jussi Lehtola <jussi.lehtola at iki.fi> 2009-05-15 06:36:39 EDT ---
rpmlint output is clean.
MUST: The spec file for the package is legible and macros are used
consistently. OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
NEEDSWORK
- License in source code is GPL+ not GPLv2. License field must be GPL+.
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. ~OK
- It's also possible to use the original srpm as the source:
Source0:
ftp://ftp.owlriver.com/pub/mirror/ORC/zerofree/zerofree-1.0.1-1orc.src.rpm
BuildRequires: cpio
# Create build directory without unpacking sources
%setup -T -c -n %{name}-%{version}
# Unpack original srpm
rpm2cpio %{SOURCE0} | cpio -i
# Unpack tar file
tar zxf zerofree-%{version}.tgz
Then you need to change directory to %{name}-%{version} before compiling
MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. N/A
MUST: Optflags are used and time stamps preserved. NEEDSWORK
- Use
make CC="gcc $RPM_OPT_FLAGS"
instead of
make RPM_OPT_FLAGS="$RPM_OPT_FLAGS"
to honor optflags and
cp -p %{SOURCE1} .
to preserve time stamp of the web page.
MUST: Packages containing shared library files must call ldconfig. N/A
MUST: A package must own all directories that it creates or require the package
that owns the directory. N/A
MUST: Files only listed once in %files listings. N/A
MUST: Debuginfo package is complete. NEEDSWORK
- Fix the optflag problem.
MUST: Permissions on files must be set properly. NEEDSWORK
- Use
%defattr(-,root,root,-)
MUST: Clean section exists. OK
MUST: Large documentation files must go in a -doc subpackage. OK
MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. OK
MUST: Header files must be in a -devel package. N/A
MUST: Static libraries must be in a -static package. N/A
MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A
MUST: If a package contains library files with a suffix then library files
ending in .so must go in a -devel package. N/A
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency. N/A
MUST: Packages does not contain any .la libtool archives. N/A
MUST: Desktop files are installed properly. N/A
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. NEEDSWORK
- The tag is %{?dist} not %{?_dist}
SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list