[Bug 501251] Review Request: perl-Tk-Stderr - Capture standard error output, display in separate window for Perl::Tk

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=501251


Jochen Schmitt <jochen at herr-schmitt.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |jochen at herr-schmitt.de
         AssignedTo|nobody at fedoraproject.org    |jochen at herr-schmitt.de
               Flag|                            |fedora-review?




--- Comment #1 from Jochen Schmitt <jochen at herr-schmitt.de>  2009-05-18 11:54:28 EDT ---
Good:
+ Basename of the SPEC files matches with package name.
+ Package name fullfill the naming guidelines.
+ URL shows on proper project home page
+ Package contains most recent release of the application
+ Could download upstream sources via spectool -g
+ Package tar ball matches which upstream sources
(md5sum: 86f0f85d24d2c1e72e1e5a039b0f0d72)
+ Package contains proper license tag
+ License tag contains GPLv2 as a valid OSS license
+ Package has proper Buildroot defintion
+ BuildRoot will be clean on start of %clean and %install
+ Package is BuiildArch noarch
+ Package has not subpackages
+ Package contains a %check stanza
+ Local build works fine
+ Rpmlint is quiete on source rpm
+ rpmlint is quiete on binary rpm
+ Local install and uninstall works fine
+ %doc stanza is small, so we don't need extra doc subpackage
+ %files stanza has proper %defattr definition
+ Files have proper files permissions
+ All package files are owned by the package
+ No packaged file is owned by another package
+ Package has proper Changelog

Bad:
- BR perl is not requires, because perl(Tk) requires perl
- Package doesn't contains verbatin copy of the license text
- Source files doesn't contains copyright notes
- README says package should have the same license as perl
  Perl is GPLV2 and Artistic. Please clarify license with
  upstream.
- Koji build fails. Please see
http://koji.fedoraproject.org/koji/taskinfo?taskID=1361022
  I assume, that we have to deactivate the %check stanza

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.