[Bug 499984] Review Request: mingw32-rxspencer - MinGW Regex library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=499984





--- Comment #6 from Thomas Sailer <t.sailer at alumni.ethz.ch>  2009-05-22 07:11:22 EDT ---
Fedora review
http://www.ftd4linux.nl/contrib/mingw32-rxspencer-alpha3.8.g4-2.fc11.src.rpm
2009-05-22

Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1370223

rpmlint output:
$ rpmlint mingw32-rxspencer*
mingw32-rxspencer-static.noarch: E:
arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/librxspencer.a
mingw32-rxspencer-static.noarch: W: no-documentation
4 packages and 1 specfiles checked; 1 errors, 1 warnings.

As per Packaging/MinGW, these errors can be ignored.

+ OK
! needs attention


+ rpmlint output
+ Package is named according to Fedora MinGW packaging guidelines
+ Specfile name matches the package base name
+ Package follows the Fedora MinGW packaging guidelines
+ License meets guidelines and is acceptable to Fedora
  BSD
+ License matches the actual package license
+ The package contains the license file (COPYRIGHT)
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm
20a95769c0adf98f0f014e0a423a0e32  rxspencer-alpha3.8.g4.tar.gz
20a95769c0adf98f0f014e0a423a0e32  x/rxspencer-alpha3.8.g4.tar.gz

n/a Package builds in mock
n/a ExcludeArch bugs filed
+ BuildRequires list all build dependencies
n/a %find_lang instead of %{_datadir}/locale/*
n/a binary RPM with shared library files must call ldconfig in %post and
%postun
+ Does not use Prefix: /usr
+ Package owns all directories it creates
+ No duplicate files in %files
+ %files has %defattr
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ Consistent use of macros
+ Package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
    Fedora MinGW guidelines allow headers in main package
+ Static libraries should be in -static
n/a Packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
n/a -devel must require the fully versioned base
n/a Packages should not contain libtool .la files
    Fedora MinGW guidelines allow .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Packages must not own files or directories owned by other packages
+ %install begins with rm -rf $RPM_BUILD_ROOT
+ Filenames must be valid UTF-8
! use %global instead of %define

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.