[Bug 474787] Review Requrest: stxxl - C++ STL drop-in replacement for extremely large datasets

bugzilla at redhat.com bugzilla at redhat.com
Sun May 24 09:21:03 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474787





--- Comment #9 from D Haley <mycae at yahoo.com>  2009-05-24 05:21:02 EDT ---
SPEC URL: http://dhd.selfip.com/427e/stxxl-4.spec
SRPM URL: http://dhd.selfip.com/427e/stxxl-1.2.1-4.fc10.src.rpm


>* Regarding %install section - you may shorten it a bit by replacing
Done.

> The %build section still doesn't honour %optflags. You should fix your spec in the following way:

I added optflags, but the macro doesn't (on my system) contain -fPIC, therefore
removing PIC causes errors when running rpmlint hence I now have

echo "OPT=%{optflags} -fPIC" >> make.settings.local

In any case, duplicate -fPICs are not going to cause any harm when seen by GCC.

>You also don't need to explicitly install doc-files. Just enumerate them in %files section properly.
Doc section updated.


> Consider adding README and TROUBLESHOOTING to %doc.  
Done.

* Sun May 24 2009 <mycae(a!t)yahoo.com> 1.2.1-4
- Used doc macro to install docs previously manually installed
- Added README and TROUBLESHOOTING to docs
- Added otpflags macro to build settings
- Use "install" program rather than cp for the install of lib


RPM Lint:
$ rpmlint -vi  stxxl.spec ../SRPMS/stxxl-1.2.1-4.fc10.src.rpm
../RPMS/i386/stxxl-1.2.1-4.fc10.i386.rpm 
stxxl.src: I: checking
stxxl.i386: I: checking
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list