[Bug 501134] Review Request: rubygem-mongrel_cluster - GemPlugin wrapper for the mongrel HTTP server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=501134


Andreas Osowski <th0br0 at mkdir.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |th0br0 at mkdir.name




--- Comment #1 from Andreas Osowski <th0br0 at mkdir.name>  2009-05-24 13:11:05 EDT ---
Package Review
==============

Key:
 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [!] Package meets the Packaging Guidelines
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested on: 
       [x] F10/i386 
 [!] Rpmlint output:
     Source RPM:
 [makerpm at hattan rubygem-mongrel_cluster]$ rpmlint
rubygem-mongrel_cluster-1.0.5-1.fc10.src.rpm 
 1 packages and 0 specfiles checked; 0 errors, 0 warnings.

     Binary RPM(s):
 [makerpm at hattan rubygem-mongrel_cluster]$ rpmlint
rubygem-mongrel_cluster-1.0.5-1.fc10.noarch.rpm 
 rubygem-mongrel_cluster.noarch: W: no-reload-entry
/etc/rc.d/init.d/mongrel_cluster
 rubygem-mongrel_cluster.noarch: E: subsys-not-used
/etc/rc.d/init.d/mongrel_cluster
 rubygem-mongrel_cluster.noarch: W: incoherent-init-script-name mongrel_cluster
 1 packages and 0 specfiles checked; 1 errors, 2 warnings.
 [x] Package is not relocatable.
 [x] Buildroot is correct
 %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined   in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
     License type: GPLv2 or Ruby
 [x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file,     containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided 
     in the spec URL.
     SHA1SUM of package: 7ff77538842c97b363137c471903f7e3
 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that 
     are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package has a %clean section, which contains rm -rf %{buildroot}.
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [x] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [x] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI 
     application.
 [x] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===
 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains 
     translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: F10/i386
 [-] Package should compile and build into binary rpms on all supported 
     architectures.
     Tested on: -
 [x] Package functions as described.
 [x] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.  

Remaining issues:
 Fix the init script issues, we can ignore the incoherent-init-script-name, but
the other two should be  fixed

 Each Ruby package must indicate the Ruby ABI version it depends on with a line
like
 Requires: ruby(abi) = 1.8

 Install docs to /usr/share/doc/<package name>-<version>/ rather than the
respective rubygems path

According to the Homepage, mongrel_cluster >= 0.2.0 is required. I take it that
this mongrel_cluster is this package? Otherwise, railsmachine (the project
linked to when clicking on mongrel_cluster) has not yet been packaged.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.