[Bug 502979] Review Request: ophcrack - Ophcrack is a free Windows password cracker based on rainbow tables

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502979





--- Comment #4 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-05-28 09:58:11 EDT ---
- Don't use macros in the URL. This makes copy-paste impossible from the spec
file.

(In reply to comment #3)
> Don't need expat-devel, I built the SRPM in mock to verify and I'd rather leave
> the Requires for personal sanity as opposed to relying on the auto-fu but if
> there is a guideline saying otherwise I will happily oblige.

http://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires

"Packages must not contain explicit Requires on libraries except when
absolutely necessary. When explicit library Requires are necessary, there
should be a spec file comment justifying it."

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.