[Bug 503256] gtkmm-utils & gtkmm-utils-devel, library used by paperbox.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503256


Jussi Lehtola <jussilehtola at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jussilehtola at fedoraproject.
                   |                            |org




--- Comment #1 from Jussi Lehtola <jussilehtola at fedoraproject.org>  2009-05-30 06:06:58 EDT ---
- Don't define %{name}, %{version}, %{release}, %{prefix} or %{packager}. The
first four are atomatic (%{name} is what is in the Name: field and so on) and
the last is not used in Fedora.

- You're missing the source URL
http://fedoraproject.org/wiki/Packaging/SourceURL

- Drop the Requires: lines altogether, ref.
http://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires
The requires are picked up automatically by RPM (except for pkgconfig which you
have to require explicitly for dir ownership).

- Drop the BuildArch line.

- Summary doesn't seem right.

- BuildRoot is obsolete, use
http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

- %prep shouldn't have an argument

- %setup should have argument -q

- No checking
 if [ -d $RPM_BUILD_ROOT ]; then rm -rf $RPM_BUILD_ROOT; fi  
is used in Fedora. Also, you need to remove it in %install, not in %build.

- Why do you delete the header files??? These should go to a -devel subpackage.

- Post and postun should be just
 %post -p /sbin/ldconfig
 %postun -p /sbin/ldconfig

- Remove .la files at end of install
 find %{buildroot} -name *.la -delete

- Use  %{_libdir} instead of %{_prefix}/lib.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.