[Bug 503256] Review Request: gtkmm-utils - C++ utility and widget library based on glibmm and gtkmm

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503256





--- Comment #7 from Gareth John <gareth.l.john at googlemail.com>  2009-05-30 13:48:18 EDT ---
Ok, cheers Mamoru i yum install redhat-rpm-config the -ba again and no errors
at all on anything.

Jussi, below are the points you gave me below and my action on them.

- Removed define %{name}, %{version}, %{release}, %{prefix} or %{packager}. 

- Removed Packager line

- Added direct source URL

- Dropped the Requires: lines altogether

- Dropped the BuildArch line.

- Summary doesn't seem right--I have now changed the summary to read like other
summaries that i have found in Fedora repo, i'm not sure if that is what you
were getting at but i hope so.

- BuildRoot was used as provided by 'rpmdev-newspec library' checked it against
requirments and it is on the preference list although is not the top preference

- Removed %prep argument

- %setup already had a -q argument

- No checking if [ -d $RPM_BUILD_ROOT ]; then rm -rf $RPM_BUILD_ROOT; fi, i
realise i did miss this on my second spec file sorry is now corrected, and is
under %install

- headers go to a -devel subpackage.

- Post and postun should is now just
 %post -p /sbin/ldconfig
 %postun -p /sbin/ldconfig

- Added Remove .la files at end of install
 find %{buildroot} -name *.la -delete

- Used  %{_libdir} instead of %{_prefix}/lib, also in addition change
%prefix/include to %{_includedir}

Other points

- I installed redhat-rpm-config and did not get any errors or warnings in the
resulting rpm

- I have made a new spec addressing all of the isues here as far as i am aware
and to the best of my knowledge. I have also changed the release to 2 as
instructed

-I now have a debug.rpm produced which did not happen before am guessing it had
something to do with redhat-rpm-config. I am not sure if it is need but have
supplied it. 
------------------------------------------------------------------

So "third time lucky", my rpmlint output is:

$ rpmlint ../RPMS/i386/gtkmm-utils-0.4.0-2.fc10.i386.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint ../RPMS/i386/gtkmm-utils-devel-0.4.0-2.fc10.i386.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint ../RPMS/i386/gtkmm-utils-0.4.0-2.fc10.i386.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

FILES..... 
http://garethsrpms.googlecode.com/files/gtkmm-utils.spec
http://garethsrpms.googlecode.com/files/gtkmm-utils-0.4.0-2.fc10.src.rpm
http://garethsrpms.googlecode.com/files/gtkmm-utils-debuginfo-0.4.0-2.fc10.i386.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.