[Bug 508521] Review Request: jettison - A JSON StAX implementation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508521


Lubomir Rintel <lkundrak at v3.sk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |lkundrak at v3.sk
         AssignedTo|nobody at fedoraproject.org    |lkundrak at v3.sk
               Flag|                            |fedora-review+




--- Comment #1 from Lubomir Rintel <lkundrak at v3.sk>  2009-11-01 05:30:23 EDT ---
Good, work; nice and clean!

1.) I suggest you use a %{version} macro here, to ease updates:
jar -cf jettison-1.1.jar -C target .

Full review:

* spec file legible, uses american english
* source matches upstream
* packages latest version
* rpmlint silent
* builds fine in mock (scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1780920)
* license ok, listed in %doc
* javadoc built, conforming to guidelines
* no prebuilt stuff
* filelists sane
* macros used consistently

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.