[Bug 526876] Review Request: php-pecl-gmagick - Provides a wrapper to the GraphicsMagick library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=526876





--- Comment #5 from Andrew Colin Kissa <andrew at topdog.za.net>  2009-11-03 05:08:06 EDT ---
OK: rpmlint must be run on every package

rpmlint rpmbuild/SRPMS/php-pecl-gmagick-1.0.2b1-2.fc11.src.rpm
rpmbuild/RPMS/i586/php-pecl-gmagick-1.0.2b1-2.fc11.i586.rpm 
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

OK: The package must be named according to the Package Naming Guidelines
OK: The spec file name must match the base package
OK: The package must meet the Packaging Guidelines
OK: The package must be licensed with a Fedora approved license
OK: The License field in the package spec file must match the actual license
OK: License text included
OK: The spec file must be written in American English
FIX: The spec file for the package MUST be legible
OK: The sources used to build the package must match the upstream source
OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture
N\A: ExcludeArch
OK: All build dependencies must be listed in BuildRequires
N\A: The spec file MUST handle locales properly
N\A: Must call ldconfig in %post and %postun
N\A: If the package is designed to be relocatable
OK: A package must own all directories that it creates
OK: A Fedora package must not list a file more than once
OK: Permissions on files must be set properly
OK: Each package must have a %clean section
FIX: Each package must consistently use macros
OK: The package must contain code, or permissable content
N\A: Large documentation files must go in a -doc subpackage
OK: If a package includes something as %doc, it must not affect the runtime of
the application
N\A: Header files must be in a -devel package
N\A: Static libraries must be in a -static package
N\A: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
N\A: Library files that end in .so (without suffix) must go in a -devel package
N\A: In the vast majority of cases, devel packages must require the base
package
OK: Packages must NOT contain any .la libtool archives
N\A: Packages containing GUI applications must include a %{name}.desktop file
OK: Packages must not own files or directories already owned by other packages
OK: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
OK: All filenames in rpm packages must be valid UTF-8


Issues to fix.

* Consistent use of macros
 - if using the %{__make} style macros then you need to be consistent, i.e use
%{__install}, %{__rm}, %{__chmod} etc

* Make the spec more eligible by formatting it correctly, at the moment the
directives at the top are not aligned.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.