[Bug 532677] Review Request: perl-HTML-SuperForm - HTML form generator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=532677


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #2 from Parag AN(पराग) <panemade at gmail.com>  2009-11-05 00:51:13 EDT ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1789154
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url(sha1sum)
65e5b7e5a3792a430ad44b07a141c027ce545e47  HTML-SuperForm-1.09.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
+ Package perl-HTML-SuperForm-1.09-1.fc12.noarch =>
Provides: perl(HTML::SuperForm) = 1.09 perl(HTML::SuperForm::Field)
perl(HTML::SuperForm::Field::Checkbox)
perl(HTML::SuperForm::Field::CheckboxGroup)
perl(HTML::SuperForm::Field::Hidden) perl(HTML::SuperForm::Field::Password)
perl(HTML::SuperForm::Field::Radio) perl(HTML::SuperForm::Field::RadioGroup)
perl(HTML::SuperForm::Field::Reset) perl(HTML::SuperForm::Field::Select)
perl(HTML::SuperForm::Field::Submit) perl(HTML::SuperForm::Field::Text)
perl(HTML::SuperForm::Field::Textarea)
Requires: perl(Carp) perl(HTML::SuperForm::Field) perl(base) perl(overload)
perl(strict)
+ Not a GUI application

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.