[Bug 526564] Review Request: unittest - C++ unit testing framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=526564


Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #10 from Thomas Spura <tomspur at fedoraproject.org>  2009-11-05 03:38:07 EDT ---
(In reply to comment #9)
> Thanks for picking this up, Thomas!

You are welcome. :)

> I added all of your changes, however:
> 
> > Requires: %{name}-devel = %{version}-%{release}
> >      to the main package, because most users would just run a
> >      'yum install unittest'
> 
> How does this work if there is no main package?

Hmm, good question ;)
I read something similar here:
http://cvs.fedoraproject.org/viewvc/rpms/boost/devel/boost.spec?view=markup

# boost is an "umbrella" package that pulls in all other boost components
Requires: ......

and no %files section.

So there will be a 'unittest' package laterly in the repos, which install
nothing, without the Requires: unittest-devel. Now it does.



Why did you a "Requires: %{name}-devel = %{version}-%{release}" in the devel
package? It should be "%{name} = %{version}-%{release}".

It's just needed in the main package. If you require it here, it won't be
installable (I believe ;)). This way the devel package requires itself and on
the first install, it will fail.

Please remove the -devel.

All other issues are done.

I don't want to wait now for another release, to see if you can delete a word
:-D -> approving this now.

________________________

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.