[Bug 532368] Review Request: ns-bola-fonts A Sans Font

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=532368


Nicolas Mailhot <nicolas.mailhot at laposte.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |john.brown009 at gmail.com
               Flag|                            |fedora-review+




--- Comment #3 from Nicolas Mailhot <nicolas.mailhot at laposte.net>  2009-11-07 10:16:39 EDT ---
Review

1. fontlint states "In GID 76 the advance width (2499) is greatert than the
stated maximum (999)" ⇒ please relay upstream

2. repo-font-audit identifies some scripts the font could easily be extended to
cover ⇒ please check and relay upstream

3. you do not need to use Mixed Case In Summary; just the first letter in the
sentence will do

4. It supports diacritics ⇒ It includes diacritics ?

5. You've forgotten to add the license file to %doc

6. It would be nice if the font metadata said OFL like the detached license
file ⇒ please relay upstream

The rest is fine

␆␆␆ APPROVED ␆␆␆

You can now continue from
http://fedoraproject.org/wiki/Font_package_lifecycle#3.a

I hope the process was pleasant, and that it will inspire you to package a
other fonts for Fedora. Please do not hesitate to suggest improvements to our
organisation or documentation on the fonts mailing list.

Thank you for another contribution to our font package pool.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.