[Bug 469474] Review Request: sovix - A website revision system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469474





--- Comment #18 from Jason Tibbitts <tibbs at math.uh.edu>  2009-11-07 21:34:03 EDT ---
A few comments:

For multiple license scenarios, you need to indicate which parts of the package
are under which license. 
http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios

I do not fully understand what requirements the AGPL places on the Fedora
package.  I don't know if we somehow have to make sure that the source is
exposed somehow.  I've asked on fedora-legal-list.

No supported version of Fedora shipped with a mysql-server older than 5.0.67 or
a php older than 5.2.6, so the versioned dependencies are kind of pointless. 
Even RHEL4 has newer versions than that.

Is there any reason why mysql-server would be required?  The upstream web page
indicates that both mysql and postgres are supported and that use of a database
is optional.  Not only that, but I can't imagine a situation that would force
the database server to be running on the same machine.  At worst you'd require
the client libraries, and even if you somehow did require the server, you're
still missing a dependency on the php interface to the database.

Your %description looks like it's been badly word-wrapped.

Generally for web applications we provide an apache config file to make the
files properly visible to the web.  Is there any specific reason for not doing
that here?  (I realize that makes the package actually require apache itself,
but that's now petty much every other packaged webapp does things.)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.