[Bug 463233] Review Request: ace-console-wui - Web App for Appliance Management

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463233


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW




--- Comment #4 from Jason Tibbitts <tibbs at math.uh.edu>  2009-11-08 14:18:22 EDT ---
This ticket is terribly old.  I'm not planning to review this package, but I
can make some comments.

Still builds OK.  rpmlint says:

  ace-console-wui.noarch: W: dangling-symlink
   /usr/share/ace/ace-console-wui/tmp /var/lib/%{inst_name}/tmp
You didn't address this above.  There's only one occurrence of "%{inst_name}"
in the spec; it's not defined anywhere, so it's just used verbatim.  This is
almost certainly some sort of oversight.

Your %description should be at least one complete sentence.  It seems to be
missing punctuation currently.

Your macro usage is inconsistent.  If for whatever reason you really want to
type a lot and use "%{__mv}" and the like, you need to use "%{__rm} as well.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.