[Bug 470830] Review Request: open64 - The Open64 compiler suite (C, C++, Fortran)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470830





--- Comment #36 from Dominik 'Rathann' Mierzejewski <rpm at greysector.net>  2009-11-08 16:44:22 EDT ---
Full review:

open64.src: W: name-repeated-in-summary Open64
open64.x86_64: W: name-repeated-in-summary Open64
open64.x86_64: W: devel-file-in-non-devel-package
/usr/lib/gcc-lib/x86_64-open64-linux/4.2.1/32/libopenmp.a
open64.x86_64: W: devel-file-in-non-devel-package
/usr/lib/gcc-lib/x86_64-open64-linux/4.2.1/32/libfortran.a
open64.x86_64: W: devel-file-in-non-devel-package
/usr/lib/gcc-lib/x86_64-open64-linux/4.2.1/libinstr.a
open64.x86_64: W: devel-file-in-non-devel-package
/usr/lib/gcc-lib/x86_64-open64-linux/4.2.1/libgcc.a
open64.x86_64: W: devel-file-in-non-devel-package
/usr/lib/gcc-lib/x86_64-open64-linux/4.2.1/libstdc++.a
open64.x86_64: W: devel-file-in-non-devel-package
/usr/lib/gcc-lib/x86_64-open64-linux/4.2.1/libopenmp.a
open64.x86_64: E: standard-dir-owned-by-package /usr/lib/gcc-lib
open64.x86_64: W: devel-file-in-non-devel-package
/usr/lib/gcc-lib/x86_64-open64-linux/4.2.1/libfortran.a
open64.x86_64: W: devel-file-in-non-devel-package
/usr/lib/gcc-lib/x86_64-open64-linux/4.2.1/32/libgcc.a
open64.x86_64: W: devel-file-in-non-devel-package
/usr/lib/gcc-lib/x86_64-open64-linux/4.2.1/32/libffio.a
open64.x86_64: W: devel-file-in-non-devel-package
/usr/lib/gcc-lib/x86_64-open64-linux/4.2.1/32/libinstr.a
open64.x86_64: W: devel-file-in-non-devel-package
/usr/lib/gcc-lib/x86_64-open64-linux/4.2.1/libffio.a
open64.x86_64: W: devel-file-in-non-devel-package
/usr/lib/gcc-lib/x86_64-open64-linux/4.2.1/libmv.a
open64.x86_64: W: devel-file-in-non-devel-package
/usr/lib/gcc-lib/x86_64-open64-linux/4.2.1/32/libstdc++.a
open64.x86_64: W: devel-file-in-non-devel-package
/usr/lib/gcc-lib/x86_64-open64-linux/4.2.1/32/libmv.a

Summary could be improved not to repeat the name.
/usr/lib/gcc-lib ownership issue is I think bogus, because no package in Fedora
owns it.
The other warnings can be ignored as this is a compiler.

Source is downloadable and MD5 hash matches.
73096667243fbfab605630b1aea380dd  open64-4.2.1-0.src.tar.bz2

Builds in mock/rawhide/x86_64.

Please ask upstream to include GPLv2 text in the next release tarball.

There's still an issue of included pre-built static libraries (find . -name
"*.a" shows a bunch), but since this is a compiler, you can ask for an initial
exception from FESCo, per
https://fedoraproject.org/wiki/Packaging/Guidelines#No_inclusion_of_pre-built_binaries_or_libraries
. Also I wasn't able to build open64 again using itself in rawhide mock.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.