[Bug 530617] Review Request: libixp - Stand-alone client/server 9P library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=530617


Michael Schwendt <mschwendt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mschwendt at gmail.com




--- Comment #2 from Michael Schwendt <mschwendt at gmail.com>  2009-11-10 17:10:25 EDT ---
> %{_libdir}/*.a

You build a static library only. You put it into the -devel package with a
virtual -static package name.

Then why do you run /sbin/ldconfig in post/postun scriptlets?


> %package -n     ixpc
> Summary:        Plan9 file protocol client
> Group:          Applications/System
> Requires:       %{name}-static = %{version}-%{release}

Why does a client binary require the static library package?


> make %{?_smp_mflags} CC="%{__cc} -c %{optflags}"

This doesn't make the package adhere to the optflags guidelines. The project's
internal CFLAGS override some of the optflags. It would be more clean if you
could patch mk/gcc.mk and append $RPM_OPT_FLAGS (or %optflags) to $CFLAGS.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.