[Bug 507083] Review Request: poco - C++ class libraries for network-centric applications

bugzilla at redhat.com bugzilla at redhat.com
Wed Nov 11 14:48:57 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507083





--- Comment #19 from Michal Schmidt <mschmidt at redhat.com>  2009-11-11 09:48:55 EDT ---
Hello Maxim.

Very good, you fixed the major issue I had with the package.

I suggest you to add a comment before the Patch0:... line to explain why the
patch is needed (Also see
http://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment
).

Have you contacted upstream developers to discuss their bundling of libraries?
It would be nice if they could stop doing that or at least make it optional
with a ./configure settings.
Though it's not strictly necessary, it is a good idea to keep a live
relationship with upstream.

Your main package "poco" depends on "poco-devel". This is unusual and I don't
recommend it. You said Boost packaging was your inspiration when you separated
the package into several subpackages, but Boost does not do this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list