[Bug 530301] Review Request: bmpanel2 - NETWM compliant panel for X

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=530301





--- Comment #12 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-11-11 13:23:46 EDT ---
Well

! For packaging issue:
* Desktop file
  - rpms containing GUI applications should also include the corresponding
    desktop files:
    https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files

* Shebang
  - From rpmlint:
--------------------------------------------------------------
bmpanel2-cfg.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/bmpanel2.py 0644 /usr/bin/env
--------------------------------------------------------------
    bmpanel2.py contains shebang, however this file does not have
    executionable permission. This script seems to be called from
    /usr/bin/bmpanel2cfg only, so the shebang doesn't seem to be
    needed and should be removed.

! For usability
- When I try bmpanel2:
---------------------------------------------------------------
[tasaka1 at localhost ~]$ bmpanel2
(2.1pre1/bmpanel.c:158) Missing theme parameter, trying default "native"
FATAL (2.1pre1/panel.c:358) Too many widgets here, try to remove one or more
---------------------------------------------------------------
  Is this normal? (note that I am using GNOME).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.