[Bug 531255] Review Request: CGSI-gSOAP - GSI plugin for gSOAP

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=531255


Steve Traylen <steve.traylen at cern.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #5 from Steve Traylen <steve.traylen at cern.ch>  2009-11-12 15:22:02 EDT ---
Review of CGSI-gSOAP.spec

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1804012

+ rpmlint clean

$ rpmlint SPECS/CGSI-gSOAP.spec
SRPMS/CGSI-gSOAP-1.3.3.2-2.20090920cvs.fc12.src.rpm RPMS/x86_64/CGSI-gSOAP-*
4 packages and 1 specfiles checked; 0 errors, 0 warnings.


+ Package name good.
+ Spec file name good.
+ Meets the pkg guidelines.
+ Spec Licensed with ASL 2.0
+ Code is also ASL 2.0
+ A LICENSE file is present.
+ English spec
+ Legible spec.
+ Source matches upstream.
diff -r --brief CGSI-gSOAP-1.3.3.2 /tmp/CGSI-gSOAP-1.3.3.2

+ Builds as per koji above.
+ Builds on all arches.
+ BR sensible.
+ No locales present.
+ ldconfig called correctly.
+ No system libs.
+ Not relocatable.
+ Owns all directories it creates or pulls them in.
+ No file duplicates.
+ All %defattr
+ %clean is cleaned.
+ Consitant use of macros.
+ Contain code.
+ No large docs.
+ %doc not needed for runtime.
+ headers in devel.
+ No pkg-config files.
+ .so in devel.
+ "-devel" requires explicitly ""
+ no .la files.
+ No gui
+ Does not own forign package files.
+ %install does clean.
+ utf8.


APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.