[Bug 517743] Review Request: PyPE - Lightweight but powerful graphical editor for developers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517743


Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |tomspur at fedoraproject.org
         AssignedTo|nobody at fedoraproject.org    |tomspur at fedoraproject.org
               Flag|                            |fedora-review?




--- Comment #5 from Thomas Spura <tomspur at fedoraproject.org>  2009-11-15 12:45:59 EDT ---
Review:

OK
- rpmlint is clean
- .desktop file ok for fedora, for RHEL see issues
- no missing BR
- no locales
- owns all dirctories, it should
- no duplicate files
- permissions ok
- %clean ok
- constantly macros
- nothing in %doc for runtime
- no subpackages needed
- latest version packaged
- sources match upstream
  both f286464ad703c3cceec2331a01d88971


Issues:
- .desktop file needs Encoding=UTF-8 if you want to ship this into RHEL.
  (at least desktop-file-validate fails without this, desktop-file-install
  probably too) Just for fedora, this is not needed.

- install: the icons are in the wrong place. When starting pype searchs in
  the python_site_packages_dir. Please install them into:
  /usr/lib/python2.6/site-packages/PyPE/icons/ and adjust the desktop file or
  place a link into the other icons directory.

- License GPLv2 and LGPLv2 and wxWidgets is partly wrong, partly unknown:
  At least plugins/exparse.py is LGPLv2+. The other files (I checked for now)
  contained no license header so you don't know, if it should be (L)GPLv2 ONLY
  or v2+. Please query upstream to add license headers and ask them, if v2 only
  of v2+.

- %doc: changelog is missing

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.