[Bug 526444] Review Request: MyGUI - Fast, simple and flexible GUI

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=526444





--- Comment #15 from Thomas Janssen <thomasj at fedoraproject.org>  2009-11-16 05:54:22 EDT ---
[fix]
Release should be: 0.2.2332svn%{?dist}
So you get a 3.0.0-0.2.2332svn package

http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Release

[fix]
You use a mix of $RPM_BUILD_ROOT and %{buildroot}

[fix]
You use %cmake but no macro for the rest of the commands like install, sed. 

[fix]
No need for VERBOSE=1 in %build

I rebuilt it here and it was running after i installed mygui and mygui-tools (i
tried the LayoutEditor).
Does it make sense to have mygui installed alone? Can one do anything with it,
without the tools?
If not, make the tools installed with the mainpackage, or maybe merge the tool
package into the main package.

As well it couldn't load anything from the list (within the load dialog). Maybe
just me.

Are the code template files needed outside a develpackage? Does the program
work without them installed? You could move them into the devel package and
make that installed by default as well.

[fix]
rpmlint -I dangling-symlink
dangling-symlink:
The target of the symbolic link does not exist within this package or its file
based dependencies.  Verify spelling of the link target and that the target is
included in a package in this package's dependency chain.

[fix]
rpmlint from installed packages:

mygui.x86_64: W: undefined-non-weak-symbol /usr/lib64/libMyGUIEngine.so.3.0.0
dlsym
mygui.x86_64: W: undefined-non-weak-symbol /usr/lib64/libMyGUIEngine.so.3.0.0
uuid_generate
mygui.x86_64: W: undefined-non-weak-symbol /usr/lib64/libMyGUIEngine.so.3.0.0
dlopen
mygui.x86_64: W: undefined-non-weak-symbol /usr/lib64/libMyGUIEngine.so.3.0.0
dlcloserpmlint -I undefined-non-weak-symbol

undefined-non-weak-symbol:
The binary contains undefined non-weak symbols.  This may indicate improper
linkage; check that the binary has been linked as expected.

You might check that linking problem with upstream.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.