[Bug 530021] Review Request: moovida - Media Center

bugzilla at redhat.com bugzilla at redhat.com
Tue Nov 17 07:02:12 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=530021





--- Comment #19 from Alex Lancaster <alexl at users.sourceforge.net>  2009-11-17 02:02:11 EDT ---
OK, to start the ball rolling here's the output for rpmlint for the binary
packages:

# rpmlint *
moovida.noarch: W: name-repeated-in-summary Moovida
moovida-base.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/elisa/core/launcher.py 0644 /usr/bin/python
moovida-base.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/elisa/core/utils/mswin32/structures.py 0644
/usr/bin/python
moovida-base.noarch: E: wrong-script-end-of-line-encoding
/usr/lib/python2.6/site-packages/elisa/core/utils/mswin32/structures.py
moovida-base.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/elisa/core/tests/test_launcher.py 0644
/usr/bin/python
moovida-plugins-bad.noarch: W: no-documentation
moovida-plugins-bad.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/elisa/plugins/database/i18n/cs/LC_MESSAGES/elisa-plugin-database.mo
moovida-plugins-bad.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/elisa/plugins/database/i18n/de/LC_MESSAGES/elisa-plugin-database.mo
moovida-plugins-bad.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/elisa/plugins/database/i18n/es/LC_MESSAGES/elisa-plugin-database.mo
moovida-plugins-bad.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/elisa/plugins/database/i18n/fr/LC_MESSAGES/elisa-plugin-database.mo
moovida-plugins-bad.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/elisa/plugins/database/i18n/gl/LC_MESSAGES/elisa-plugin-database.mo
moovida-plugins-bad.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/elisa/plugins/database/i18n/hu/LC_MESSAGES/elisa-plugin-database.mo
moovida-plugins-bad.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/elisa/plugins/database/i18n/it/LC_MESSAGES/elisa-plugin-database.mo
moovida-plugins-bad.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/elisa/plugins/database/i18n/pl/LC_MESSAGES/elisa-plugin-database.mo
moovida-plugins-bad.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/elisa/plugins/database/i18n/pt_BR/LC_MESSAGES/elisa-plugin-database.mo
moovida-plugins-bad.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/elisa/plugins/dvd/i18n/cs/LC_MESSAGES/elisa-plugin-dvd.mo
moovida-plugins-bad.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/elisa/plugins/dvd/i18n/de/LC_MESSAGES/elisa-plugin-dvd.mo
moovida-plugins-bad.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/elisa/plugins/dvd/i18n/es/LC_MESSAGES/elisa-plugin-dvd.mo
moovida-plugins-bad.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/elisa/plugins/dvd/i18n/fr/LC_MESSAGES/elisa-plugin-dvd.mo
moovida-plugins-bad.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/elisa/plugins/dvd/i18n/gl/LC_MESSAGES/elisa-plugin-dvd.mo
moovida-plugins-bad.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/elisa/plugins/dvd/i18n/hu/LC_MESSAGES/elisa-plugin-dvd.mo
moovida-plugins-bad.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/elisa/plugins/dvd/i18n/it/LC_MESSAGES/elisa-plugin-dvd.mo
moovida-plugins-bad.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/elisa/plugins/dvd/i18n/pl/LC_MESSAGES/elisa-plugin-dvd.mo
moovida-plugins-bad.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/elisa/plugins/dvd/i18n/pt_BR/LC_MESSAGES/elisa-plugin-dvd.mo
moovida-plugins-bad.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/elisa/plugins/poblesec/i18n/cs/LC_MESSAGES/elisa-plugin-poblesec.mo
moovida-plugins-bad.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/elisa/plugins/poblesec/i18n/de/LC_MESSAGES/elisa-plugin-poblesec.mo
moovida-plugins-bad.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/elisa/plugins/poblesec/i18n/es/LC_MESSAGES/elisa-plugin-poblesec.mo
moovida-plugins-bad.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/elisa/plugins/poblesec/i18n/fr/LC_MESSAGES/elisa-plugin-poblesec.mo
moovida-plugins-bad.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/elisa/plugins/poblesec/i18n/gl/LC_MESSAGES/elisa-plugin-poblesec.mo
moovida-plugins-bad.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/elisa/plugins/poblesec/i18n/hu/LC_MESSAGES/elisa-plugin-poblesec.mo
moovida-plugins-bad.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/elisa/plugins/poblesec/i18n/it/LC_MESSAGES/elisa-plugin-poblesec.mo
moovida-plugins-bad.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/elisa/plugins/poblesec/i18n/pl/LC_MESSAGES/elisa-plugin-poblesec.mo
moovida-plugins-bad.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/elisa/plugins/poblesec/i18n/pt_BR/LC_MESSAGES/elisa-plugin-poblesec.mo
moovida-plugins-good.noarch: W: no-documentation
moovida-plugins-good.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/elisa/plugins/base/i18n/cs/LC_MESSAGES/elisa-plugin-base.mo
moovida-plugins-good.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/elisa/plugins/base/i18n/de/LC_MESSAGES/elisa-plugin-base.mo
moovida-plugins-good.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/elisa/plugins/base/i18n/es/LC_MESSAGES/elisa-plugin-base.mo
moovida-plugins-good.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/elisa/plugins/base/i18n/fr/LC_MESSAGES/elisa-plugin-base.mo
moovida-plugins-good.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/elisa/plugins/base/i18n/gl/LC_MESSAGES/elisa-plugin-base.mo
moovida-plugins-good.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/elisa/plugins/base/i18n/hu/LC_MESSAGES/elisa-plugin-base.mo
moovida-plugins-good.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/elisa/plugins/base/i18n/it/LC_MESSAGES/elisa-plugin-base.mo
moovida-plugins-good.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/elisa/plugins/base/i18n/pl/LC_MESSAGES/elisa-plugin-base.mo
moovida-plugins-good.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/elisa/plugins/base/i18n/pt_BR/LC_MESSAGES/elisa-plugin-base.mo
4 packages and 0 specfiles checked; 4 errors, 39 warnings.

Some issues that need to be fixed are:

1. addressing the file permissions
2. one line encoding issue
3. handling the locale files correctly, see:
https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files

The no documentation thing can probably be ignored.  It also points out the
problem with the duplicate name in summary that I already pointed out.

The SRPMS pretty much pass the tests, with the exception of the Summary already
noted:

# rpmlint *.src.rpm
moovida.src: W: name-repeated-in-summary Moovida
3 packages and 0 specfiles checked; 0 errors, 1 warnings.

And, yes, it would be great if you could use your webspace on fedorapeople.org
to post the updated .specs and srpms for the subsequent iteration.  Thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list