[Bug 528108] Review Request: Vuurmuur - Firewall manager built on top of iptables

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=528108





--- Comment #11 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-11-17 13:17:08 EDT ---
For -3:

* Parallel make
-------------------------------------------------------------------
   110  cd ../vuurmuur_conf-%{version}
   111  %configure \
   112          --with-libvuurmuur-includes=${LIBVUDIR}/src/ \
   113          --with-libvuurmuur-libraries=${LIBVUDIR}/src/.libs/
   114  
   115  # Configure ignores --disable-rpath so we have to solve it this way
   116  sed -i 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g'
libtool
   117  sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool
   118  make %{?_smp_mflags}
-------------------------------------------------------------------
  - With koji this parallel make (line 118) failed with -j4:
    http://koji.fedoraproject.org/koji/taskinfo?taskID=1812437

    For this part please disable parallel make and comment on the spec file
    that parallel make fails on this part.

* -daemon <-> -tui
(In reply to comment #7)
> So, I added some configuration files, and switched services from shared
> directory to /etc/vuurmuur but the user has to start vuurmuur_conf tool to
> create initial configuration. 
  - Well, then 
    * it seems more logical that -daemon subpackage should have 
      "Requires: %{name}-tui = %{version}-%{release}" (in such case
      "Requires: %{name} = %{version}-%{release}" on -daemon subpackage
      is no longer needed because -tui subpackage already depends on
      the main package).

    * Or maybe -daemon and -tui subpackages should just be unified.

* Directory ownership issue
  - Still the following directories are not owned by any packages:
--------------------------------------------------------------------
%{_libdir}/vuurmuur/plugins/
--------------------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.