[Bug 491088] Review Request: rhncfg - Red Hat Network Configuration Client Libraries

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=491088





--- Comment #5 from Miroslav Suchý <msuchy at redhat.com>  2009-11-18 04:07:13 EDT ---
> rhnlib seems to be a special case and you can ignore those warning
yes, it is special case

> but please remove libselinux-python.
I would like, but if I remove it, it is not included. I build test package with
that Requirese: removed and got:
$ rpm -qpR
/tmp/spacewalk-build/rpmbuild-rhncfg-git-c9cd2e0cf23a7bd6eaed93435c305d7b1c975378/noarch/rhncfg-5.9.13-1.git.c9cd2e0cf23a7bd6eaed93435c305d7b1c975378.noarch.rpm
python
rhnlib
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(VersionedDependencies) <= 3.0.3-1

> License should be "GPLv2 and Python" (e.g. compile.py is based on
> Python-licensed code) - asked spot about this to be sure
Did not know. Done.

> PYTHON-LICENSES.txt should be added to %doc
Done

> This require should be moved up to the main package.
Done.

> Therefore please remove all provides from
> the spec file unless you have a proper explanation for them.
Old heritage. I tracked it to year 2003 and could not find reason, why it has
been added. Dropped.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.