[Bug 532874] Review Request: xorg-x11-drv-wacom - Xorg X11 wacom input driver

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=532874


Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #9 from Thomas Spura <tomspur at fedoraproject.org>  2009-11-18 14:39:17 EDT ---
> Obsolete linuxwacom, don't Conflict with it.

I think, this can't work, because in bug #538036, you say, I should copy the
fdi file from linuxwacom and that this file will be included in this package
too. If you don't rename this file, when adding here, this would probably cause
problems, when both are installed.
If you rename the file -> Obsolete,
no rename -> Conflict.
Maybe name it 10-wacom.fdi...

> > - rpmlint: $ rpmlint xorg-x11-drv-wacom.spec
> This didn't give me any of the warnings when I ran it here, is there a specific
> flag I have to provide?

No, this was a full copy from my terminal. I ran rpmlint on the spec, the
src.rpm and all generated rpms in one command. See one line below:
- rpmlint: $ rpmlint xorg-x11-drv-wacom.spec
xorg-x11-drv-wacom-0.10.0-1.fc12.src.rpm x86_64/xorg-x11-drv-wacom-*


One last thing:
- run make %{?_smp_mflags} and not just make to enable building targets in
parallel, see https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make

____________________


All other issues, except the 'non-working' at least for me, are fixed:

-> APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.