[Bug 538558] Review Request: kde-partitionmanager - KDE Partition Manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=538558


Jochen Schmitt <jochen at herr-schmitt.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |jochen at herr-schmitt.de
               Flag|                            |fedora-review?




--- Comment #1 from Jochen Schmitt <jochen at herr-schmitt.de>  2009-11-18 16:38:50 EDT ---
Good:
+ Basename of the SPEC file matches with package name
+ Package name fullfill naming guidelines
+ Package has proper BuildRoot defintion
+ Consitently usage of rpm macros
+ License tag declared GPLv2+ as a valid OSS license
+ Copyright notes in source files matches with
  declaration of license tag
+ Package contains verbatin copy of the license text
+ URL tags shows on proper project homepage
+ Could download upstream sources via spectool -g
+ Packaged upstream tar ball matches with upstream
(md5sum: 07046e0c61ca3f06129580ffd7f9c66e)
+ Package has no subpackages
+ Rpmlint is silent on source package
+ Rpmlint is silent on debuginfo package
+ Debuginfo files contains source files
+ buildroot will be cleaned at the beginning of %clean and %install
+ Package has small %doc stanza, so no separate doc subpackage
  in required.
+ Local build works fine
+ Build is SMP clean
+ Local install and uninstall of the package works fine
+ Start of the application works without crash
+ Scratch build on koji works properly
+ Files stanza has proper default permisions
+ Files stanza has no duplicate entries
+ All fires and dirs are owned by the package
+ No files or dirs belong to another package
+ Package has proper Changelog stanza

Bad
- Rpmlint complaints on binary package:
  $ rpmlint kde-partitionmanager-1.0.0-1.fc11.x86_64.rpm
  kde-partitionmanager.x86_64: E: invalid-soname
/usr/lib64/libpartitionmanagerprivate.so libpartitionmanagerprivate.so
  1 packages and 0 specfiles checked; 1 errors, 0 warnings.
  Please contact upstream author to fix it.
- Please mof the desktop-file-validate command to the %install stanza
- qt4-devel is not required as a BR, because kdelibs4-devel requires
  qt4-devel

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.