[Bug 538326] Review Request: perl-LWP-Online - Module for accessing web by proccess

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=538326


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-11-19 00:35:12 EDT ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1813700
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url (sha1sum)
f1391f2b17d2e18b1c1396fb58a52cdf7efe40ec  LWP-Online-1.07.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=5, Tests=3,  1 wallclock secs ( 0.03 usr  0.01 sys +  0.23 cusr  0.03
csys =  0.30 CPU)
+ Package perl-LWP-Online-1.07-1.fc13.noarch =>
Provides: perl(LWP::Online) = 1.07
Requires: perl >= 0:5.005 perl(Carp) perl(LWP::Simple) perl(strict) perl(vars)

+ Not a GUI application

Suggestions:
1) please remove following Requires as I see they are auto pulled by yum
Requires:       perl(LWP::Simple)
Requires:       perl(URI)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.