[Bug 539230] Review Request: perl-Authen-Simple - Simple Authentication

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=539230


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-11-20 01:16:51 EDT ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1818826
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url (sha1sum)
5c58c9f8bd279214121a4cff0a96a33fe3ea5097  Authen-Simple-0.4.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=9, Tests=54,  1 wallclock secs ( 0.04 usr  0.03 sys +  0.33 cusr  0.12
csys =  0.52 CPU)
+ Package perl-Authen-Simple-0.4-1.fc13.noarch =>
Provides: perl(Authen::Simple) = 0.4 perl(Authen::Simple::Adapter)
perl(Authen::Simple::Apache) perl(Authen::Simple::Log)
perl(Authen::Simple::Password)
Requires: perl(Authen::Simple::Adapter) perl(Authen::Simple::Log)
perl(Authen::Simple::Password) perl(Carp) perl(Crypt::PasswdMD5)
perl(Digest::MD5) perl(Digest::SHA) perl(IO::Handle) perl(MIME::Base64)
perl(Params::Validate) perl(base) perl(constant) perl(strict) perl(warnings)
+ Not a GUI application

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.