[Bug 539837] Review Request: mppenc - Musepack audio compressor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=539837





--- Comment #2 from David Timms <dtimms at iinet.net.au>  2009-11-21 08:41:18 EDT ---
Things to look at:
1. Missing following stanza (as indicated by rpmlint).

%clean
rm -rf $RPM_BUILD_ROOT


2. missing buildroot stuff
BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)


3. order of stanzas. It seems that normally Name comes first before summary
(and some of the other items based on the order that newspec creates. Is there
a good reason to go against suggestions from rpmdev-newspec ?

4. the  Install file mentions ossaudio (bsd only). is that a real requirement ?
(I wouldn't think so, since it shouldn't need to actually use audio output or
input.)

5. Install also mentions use of:
'cmake -DCMAKE_INSTALL_PREFIX:=/myPath'
Seems it installs into a fedora happy location anyway. So I do not know if this
is needed.

6. patch cmake. Is this to ignore the default build params and ensure Fedora's
get used. It might be useful to explain that above the patch definition, but
I'm not insisting.

7. license: website says License: GNU LGPL
most src files state: License: GNU LGPL v2.1 or later.
It seems the intent is probably LGPLv2+ which matches a standard Fedora 
license designator, that is provided in the spec. Is it worth querying upstream
to get some license info in the remaining src files "


OK: named as upstream package.

OK. md5sum in archive inside src.rpm matches upstream:
$ md5sum mppenc-1.16.tar.bz2 mppenc-1.16-0.1.fc11.src/mppenc-1.16.tar.bz2
f1456141283814efcc012cfa15609bc6  mppenc-1.16.tar.bz2
f1456141283814efcc012cfa15609bc6  mppenc-1.16-0.1.fc11.src/mppenc-1.16.tar.bz2

OK. rpmbuild -ba succeeds in creating src, bin and bin-debuginfo rpms.

OK. app works as expected to create a mpc file from wav input. The created mpc
is playable with audacious-plugins. on i686

OK. the remaining must items pass, or are not relevant to this package. Most of
the should items are also not relevant.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.