[Bug 508922] Review Request: system-config-selinux - GUI Code for system-config-selinux, polgen, and lockdown

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508922


David Timms <dtimms at iinet.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |dtimms at iinet.net.au
               Flag|                            |fedora-review+




--- Comment #28 from David Timms <dtimms at iinet.net.au>  2009-11-23 15:23:01 EDT ---
(In reply to comment #27)
> If we release
> this, we can remove that package and concentrate on fixing this tool  
OK, assuming the release early, release often mantra, and I'm expecting this
would only be added to F13 (rawhide).

One thing concerns me:
ln -sf %{_datadir}/system-config-selinux/polgengui.py \
       %{buildroot}%{_bindir}/selinux-polgengui
ln -sf %{_datadir}/system-config-selinux/system-config-selinux.py \
       %{buildroot}%{_bindir}/system-config-selinux

$ rpm --eval %{_bindir}
/usr/bin

$ rpm --eval %{buildroot}
/home/davidt/rpmbuild/BUILDROOT/%{name}-%{version}-%{release}.i386

$ rpm --eval %{_datadir}
/usr/share

So these are making a link from / to the raw build machine's 
buildroot location ?
    I'm probably misunderstanding how that works.

Otherwise, given the main app doesn't even start up, I'm happy enough to
approve the package, so that it is in rawhide as soon as possible.

  Please consider the package APPROVED by dtimms.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.