[Bug 499476] Review Request: orbited - A browser(javascript)->tcp bridge

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=499476


Fabian Deutsch <fabian.deutsch at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fabian.deutsch at gmx.de




--- Comment #9 from Fabian Deutsch <fabian.deutsch at gmx.de>  2009-11-23 20:14:53 EDT ---
X Daemon
There is still need for some initscript/upstart-integration and config-file as
discussed earlier.
It is a standalone daemon, is it?

X User
As noted in http://www.orbited.org/browser/trunk/daemon/orbited.cfg, the daemon
can fall back to some user, so it might be good to add an appropriate user.

X SPEC: Wrong indentation of Source1 and Patch0

X KOJI: Ok.

X RPMLINT:
$ rpmlint -v /home/fabiand/Downloads/orbited-0.7.10-1.fc12.*
orbited.noarch: I: checking
orbited.noarch: W: spelling-error-in-summary en_US javascript
orbited.noarch: W: spelling-error-in-summary en_US tcp
orbited.noarch: W: spelling-error-in-description en_US plugins
orbited.noarch: W: no-documentation
orbited.src: I: checking
orbited.src: W: spelling-error-in-summary en_US javascript
orbited.src: W: spelling-error-in-summary en_US tcp
orbited.src: W: spelling-error-in-description en_US plugins
orbited.src: W: mixed-use-of-spaces-and-tabs (spaces: line 12, tab: line 4)
2 packages and 0 specfiles checked; 0 errors, 8 warnings.
- Correct spelling
- Add documentation

Note: This is my first review, thanks for some constructive feedback :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.