[Bug 541317] Review Request: perl-CGI-Application-Structured - Medium-weight, MVC, DB web framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541317


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-11-26 01:45:36 EDT ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1831408
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url (sha1sum)
45930fb4af73e549dbc02fd4639be21110e66c0e 
CGI-Application-Structured-0.003.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=2, Tests=2,  0 wallclock secs ( 0.02 usr  0.01 sys +  0.16 cusr  0.03
csys =  0.22 CPU)
+ Package  perl-CGI-Application-Structured-0.003-1.fc13.noarch=>
Provides: perl(CGI::Application::Structured) = 0.003
Requires: perl(CGI::Application::Plugin::AutoRunmode)
perl(CGI::Application::Plugin::ConfigAuto) perl(CGI::Application::Plugin::DBH)
perl(CGI::Application::Plugin::DBIC::Schema)
perl(CGI::Application::Plugin::FillInForm)
perl(CGI::Application::Plugin::Forward)
perl(CGI::Application::Plugin::LogDispatch)
perl(CGI::Application::Plugin::Redirect)
perl(CGI::Application::Plugin::Session)
perl(CGI::Application::Plugin::SuperForm) perl(CGI::Application::Plugin::TT)
perl(CGI::Application::Plugin::ValidateRM) perl(base) perl(strict) perl(vars)
perl(warnings)
+ Not a GUI application

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.