[Bug 541589] Review Request: sqljet - Pure Java SQLite

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541589


Lubomir Rintel <lkundrak at v3.sk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




--- Comment #2 from Lubomir Rintel <lkundrak at v3.sk>  2009-11-26 16:03:32 EDT ---
3.) You do not run the test suite
Please do so, ideally in %check section. Seems like you'd need to add a
dependency on hamcrest.

I'd also suggest replacing Summary with something more descriptive, (i.e.
adding "database library" at the end or something like that).

The rest looks well
* Named and versioned in accordance with guidelines
* License ok, license tag correct, license present in package documentation
* spec file clean and legible
* filelist sane

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.