[Bug 226484] Merge Review: telnet

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226484





--- Comment #3 from Adam Tkac <atkac at redhat.com>  2009-11-27 07:10:18 EDT ---
(In reply to comment #1)
> rpmlint not silent:
> 
> telnet.src:31: W: buildprereq-use ncurses-devel
> telnet.src:331: W: macro-in-%changelog setup
> telnet.src: W: mixed-use-of-spaces-and-tabs (spaces: line 79, tab: line 81)
> telnet.src: W: patch-not-applied Patch9: telnet-0.17-env-5x.patch
> telnet.src: W: patch-not-applied Patch17: telnet-0.17-linemode.patch
> telnet.src: W: summary-ended-with-dot The client program for the telnet remote
> login protocol.

^^^ Fixed.

> telnet.src: W: no-url-tag

The telnet client is based on BSD telnet. I've found no official URL for that.
I guess source was created as a CVS checknout from (Free)BSD repository.

> Buildroot is not among the preferred ones.

Fixed.

> Where does the telnet-client.tar.gz archive come from?

As I wrote above I guess it is checkout from FreeBSD repository.

> And also how was generated:
> telnet-client-cvs.patch

It is probably update from FreeBSD repo. Note that this decision was made by
previous maintainer. It's not so wise to completely throw away FreeBSD source
and replace it by "official" code. It will cause many regressions.

> What is all the strange pie stuff?

Important servers are usually compiled as PIEs. Due low-level architecture
differences s390 & s390x needs -fPIE. All other supported archs need -fpie.

> I would suggest using -p in 
> install -p -m644 %SOURCE3 ${RPM_BUILD_ROOT}/etc/xinetd.d/telnet
> 
> It would certainly be better to use %{_sysconfdir} instead of /etc.
> 
> I suggest using %defattr(-,root,root,-) instead of %defattr(-,root,root)
> 
> Also -g is already in RPM_OPT_FLAGS?
> 
> is
> export CC_FLAGS="$CC_FLAGS"
> really useful since CC_FLAGS looks empty?  

^^^ Fixed.

All issues should be fixed in telnet-0.17-46.fc13. Rest of rpmlint warnings are
not problems:

$ rpmlint telnet-0.17-46.fc13.src.rpm 
telnet.src: W: spelling-error-in-summary en_US login
telnet.src: W: name-repeated-in-summary C Telnet
telnet.src: W: no-url-tag

$ rpmlint telnet-server-0.17-46.fc13.x86_64.rpm 
telnet-server.x86_64: W: spelling-error-in-summary en_US login
telnet-server.x86_64: W: spelling-error-in-description en_US logins
telnet-server.x86_64: W: spelling-error-in-description en_US xinetd
telnet-server.x86_64: W: no-url-tag

$ rpmlint telnet-0.17-46.fc13.x86_64.rpm 
telnet.x86_64: W: spelling-error-in-summary en_US login
telnet.x86_64: W: name-repeated-in-summary C Telnet
telnet.x86_64: W: no-url-tag

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.