[Bug 530806] Review Request: Pyrit - A GPGPU-driven WPA-PSK key cracker
bugzilla at redhat.com
bugzilla at redhat.com
Fri Nov 27 13:49:30 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530806
Thomas Spura <tomspur at fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tomspur at fedoraproject.org
--- Comment #2 from Thomas Spura <tomspur at fedoraproject.org> 2009-11-27 08:49:28 EDT ---
Just a few comments, because I'm no sponsor anyway:
- Some tests are currently failing ( to long to copy&paste here )
- Missing Requires: scapy ( one test fails because of this... )
- The license (as you noted in setup.py) should be GPLv3+
- tests should be part of doc and not installed in /usr/share, except you need
them on runtime.
Please delete all install* lines from %install and include the tests in the
%files section as:
%doc test/*
This will copy all files from test to /usr/share/doc/%{name}-%{version}/
- You don't own %{_datadir}/%{name}/ just the subfiles.
If this package will be deleted on any system out there, the folder
%{_datadir}/%{name}/ will stay there...
When you install the tests with %doc, this won't be needed anymore.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list