[Bug 494695] Review Request: qutim - Multiplatform Instant Messenger on Qt4

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=494695





--- Comment #18 from Peter Lemenkov <lemenkov at gmail.com>  2009-11-29 12:03:47 EDT ---
(In reply to comment #17)
> Thank you. All mentioned issue fixed, except one:
> > * Also consider removing entirely %doc sections from plugin sub-packages.  
> paths fixed instead, and in plugins packages included its docs (only mrim do
> not have it because it is absent in upstream tarball)
> 
> http://koji.fedoraproject.org/koji/taskinfo?taskID=1832695
> 
> http://hubbitus.net.ru/rpm/Fedora11/qutim/qutim-0.2.0-1.20.fc11.src.rpm  

Some new issues :)

* In main package you forgot to mark owned directory %{_libdir}/%{name} as %dir
* I believe, that instead of installing small icon to
%{buildroot}/%{_datadir}/icons/hicolor/16x16/ you intended to install to
%{buildroot}/%{_datadir}/icons/hicolor/16x16/apps

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.