[Bug 542292] Review Request: mintmenu - gnome-panel menu from LinuxMint

bugzilla at redhat.com bugzilla at redhat.com
Mon Nov 30 08:04:27 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=542292


Terje Røsten <terjeros at phys.ntnu.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |terjeros at phys.ntnu.no




--- Comment #4 from Terje Røsten <terjeros at phys.ntnu.no>  2009-11-30 03:02:31 EDT ---
Comments marked with ###


#%global _libdir /usr/lib

### Remove

Summary: Advanced Gnome menu
Name: mintmenu
Version: 4.9.0

### align Name tag?

BuildRequires: python-devel
Requires: deskbar-applet, tracker, python >= 2.4, python < 3.0, pyxdg,
gnome-python2-gnomedesktop, pygtk2, pygtk2-libglade, alacarte

### Split this line, many reviewers like only one package one each line.


%description
One of the most advanced menus under Linux. MintMenu supports filtering, 
favorites, easy-uninstallation, autosession, and many other features

### You could be a bit more informative here.

%prep
%setup -q -n mintmenu


%install
rm -rf %{buildroot}
mkdir %{buildroot}
cp -R usr %{buildroot}/

### I would change that to cp -a ...

cp %SOURCE1 %{buildroot}/%{_libdir}/linuxmint/mintMenu/

### And this to cp -a %{SOURCE1} ...

%post
%postun

### Remove these

%files
%defattr(-,root,root,-)
   %attr(0755, root, root) %{_bindir}/mintmenu
   %{_libdir}/bonobo/servers/mintMenu.server

   %{_libdir}/linuxmint/mintMenu/applications.list
   %{_libdir}/linuxmint/mintMenu/compile.py

### You have to redo the file listing, should the package own 
### %{_libdir}/linuxmint and %{_libdir}/linuxmint/mintMenu?
### Remove the leading spaces.

   %{_libdir}/linuxmint/mintMenu/compile.pyc
   %{_libdir}/linuxmint/mintMenu/dotted.png
   %{_libdir}/linuxmint/mintMenu/icon.png

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list