[Bug 526564] Review Request: unittest - C++ unit testing framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=526564


Michael Schwendt <mschwendt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |526567,
                   |                            |177841(FE-NEEDSPONSOR)
  Status Whiteboard|                            |NotReady




--- Comment #1 from Michael Schwendt <mschwendt at gmail.com>  2009-10-01 05:38:07 EDT ---
> I'm not a packager yet, but I have a sponsor

Really? This package needs a lot of love, since it isn't ready yet and doesn't
pass the guidelines

Btw, your sponsor must be the one to do the final package review:
https://fedoraproject.org/wiki/Package_Review_Process#Reviewer


> rpmlint is a bit scary

Well, it's more scary that you don't comment on those rpmlint warnings and
errors at all. Some of the errors found by rpmlint are obvious packaging
mistakes. You don't even ask any questions about that. Also run rpmlint on the
src.rpm.

Please become familiar with the Packaging Guidelines:
https://fedoraproject.org/wiki/Packaging:Guidelines

In particular take a look at
https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries

But that's not the only problem. At the top of the list are misplaced files,
such as

-rw-r--r--  /usr/share/doc/collection.html
-rw-r--r--  /usr/share/doc/default.css
-rw-r--r--  /usr/share/doc/index.html
-rw-r--r--  /usr/share/doc/misc.html
-rw-r--r--  /usr/share/doc/mixin.html
-rw-r--r--  /usr/share/doc/setup-teardown.html
-rw-r--r--  /usr/share/doc/test-advanced.html
-rw-r--r--  /usr/share/doc/test.html

and

drwxr-xr-x  /usr/share/doc/unittest-devel-0.50/test
-rw-r--r--  /usr/share/doc/unittest-devel-0.50/test/ExistingBaseTest.cpp
-rw-r--r--  /usr/share/doc/unittest-devel-0.50/test/ExistingBaseTest.d
-rw-r--r--  /usr/share/doc/unittest-devel-0.50/test/ExistingBaseTest.o
-rw-r--r--  /usr/share/doc/unittest-devel-0.50/test/Helper.cpp
-rw-r--r--  /usr/share/doc/unittest-devel-0.50/test/Helper.d
-rw-r--r--  /usr/share/doc/unittest-devel-0.50/test/Helper.hpp
-rw-r--r--  /usr/share/doc/unittest-devel-0.50/test/Helper.o
-rw-r--r--  /usr/share/doc/unittest-devel-0.50/test/Makefile
-rw-r--r--  /usr/share/doc/unittest-devel-0.50/test/Makefile.in
-rw-r--r--  /usr/share/doc/unittest-devel-0.50/test/RegistryTest.cpp
-rw-r--r--  /usr/share/doc/unittest-devel-0.50/test/RegistryTest.d
-rw-r--r--  /usr/share/doc/unittest-devel-0.50/test/RegistryTest.o
-rw-r--r--  /usr/share/doc/unittest-devel-0.50/test/SuiteTest.cpp
-rw-r--r--  /usr/share/doc/unittest-devel-0.50/test/SuiteTest.d
-rw-r--r--  /usr/share/doc/unittest-devel-0.50/test/SuiteTest.o
-rw-r--r--  /usr/share/doc/unittest-devel-0.50/test/TestHolderTest.cpp
-rw-r--r--  /usr/share/doc/unittest-devel-0.50/test/TestHolderTest.d
-rw-r--r--  /usr/share/doc/unittest-devel-0.50/test/TestHolderTest.o
-rw-r--r--  /usr/share/doc/unittest-devel-0.50/test/TestPtrTest.cpp
-rw-r--r--  /usr/share/doc/unittest-devel-0.50/test/TestPtrTest.d
-rw-r--r--  /usr/share/doc/unittest-devel-0.50/test/TestPtrTest.o
-rw-r--r--  /usr/share/doc/unittest-devel-0.50/test/TestTest.cpp
-rw-r--r--  /usr/share/doc/unittest-devel-0.50/test/TestTest.d
-rw-r--r--  /usr/share/doc/unittest-devel-0.50/test/TestTest.o
-rw-r--r--  /usr/share/doc/unittest-devel-0.50/test/unittesttest
-rw-r--r--  /usr/share/doc/unittest-devel-0.50/test/unittesttest.cpp
-rw-r--r--  /usr/share/doc/unittest-devel-0.50/test/unittesttest.d
-rw-r--r--  /usr/share/doc/unittest-devel-0.50/test/unittesttest.hpp
-rw-r--r--  /usr/share/doc/unittest-devel-0.50/test/unittesttest.o

That's why rpmlint prints the arch-dependent-file-in-usr-share errors.
/usr/share is for arch-independent data.


-rw-r--r--  /usr/share/doc/unittest-devel-0.50/INSTALL

That one is irrelevant to RPM package end-users.


> %{__sed} -i 's|/usr/lib|%{buildroot}%{_libdir}|g' Makefile

That transformation breaks the build on 64-bit platforms where libdir is
/usr/lib64.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.