[Bug 225697] Merge Review: distcache

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225697


Steve Traylen <steve.traylen at cern.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?




--- Comment #1 from Steve Traylen <steve.traylen at cern.ch>  2009-10-01 14:56:15 EDT ---
Hi,

I presume a merge review is the same as a normal review just
a different starting point:

Comments:

1) $ rpmlint distcache.spec 
distcache.spec:57: E: use-of-RPM_SOURCE_DIR

Yes you should not install from the SOURCE_DIR
but instead in %prep move things to unpacked
directory. i.e.
cp -p %{SOURCE1} .
after your %setup.

2) The 3 patches have no comments or upstream bugs attached.

3) The useradd section in the %post could be a litte more complicated as
   recommended here:

https://fedoraproject.org/wiki/Packaging/UsersAndGroups

(It's odd its in the %post and not in the %pre, is it really not needed
 till then? It looks like it may be in the passwd file already though.

4) The two scripts in the .src.rpm should not be executable.

5) What about splitting to a client and server package? Is that sensible?

6) You could mark /etc/sysconfig/distcache as a %gfile

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.