[Bug 521909] Review Request: ne7ssh - SSH Library is a Secure Shell client software written in C++

bugzilla at redhat.com bugzilla at redhat.com
Thu Oct 1 20:39:04 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=521909





--- Comment #20 from Michael Schwendt <mschwendt at gmail.com>  2009-10-01 16:39:03 EDT ---
> What is a big problem set nw7ssh-devel as dependency for nw7ssh-doc?

It creates a superfluous chain of dependencies. It adds several packages, which
are not really needed by anyone who may want to evaluate the API Documentation
(such as the included PDF). At least the following four packages would be
pulled in: ne7ssh-devel + ne7ssh + botan-devel + botan. It's unexpected for a
Documentation package to have such requirements.


> Or you think I should expand my patch on examples too?

No. Unless you insist on claiming it would be important that users could simply
build them by executing "make" without having to install any needed packages.
;-)

Just like many _optional_ test-suites, such examples often are out-of-sync with
the main library anyway. Especially if they are not built by default. That
means less users will build them and will notice build problems. Less users
will report build failures with _optional_ files to upstream.


> No special tools needed.

You misunderstood me. Surely, a PDF file needs a special viewer to display it.
With that my earlier comments should be more clear.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list