[Bug 526916] Review Request: liborc - The Oil Runtime Compiler

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=526916


Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.gieseking at uos.de




--- Comment #2 from Martin Gieseking <martin.gieseking at uos.de>  2009-10-02 11:42:11 EDT ---
Some quick comments:

- the package name should be "orc" without the leading "lib"

- add Requires: pkgconfig to the devel package

- remove the rpaths from libtool (see
http://fedoraproject.org/wiki/Packaging:Guidelines#Beware_of_Rpath)

- in %files tools, swap the %doc and %defattr lines


$ rpmlint /var/lib/mock/fedora-11-x86_64/result/liborc-*
liborc.src:75: E: files-attr-not-set
liborc.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/liborc-pixel-0.4.so.0.0.0 ['/usr/lib64']
liborc.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/liborc-test-0.4.so.0.0.0 ['/usr/lib64']
liborc.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/liborc-float-0.4.so.0.0.0 ['/usr/lib64']
liborc-tools.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/orc/generate_opcodes_sys ['/usr/lib64']
liborc-tools.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/orc/example1
['/usr/lib64']
liborc-tools.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/orc/exec_opcodes_float ['/usr/lib64']
liborc-tools.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/orc/compile_opcodes_sys_c ['/usr/lib64']
liborc-tools.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/orc/generate_xml_table2 ['/usr/lib64']
liborc-tools.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/orc/compile_opcodes_float ['/usr/lib64']
liborc-tools.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/orc/test-schro
['/usr/lib64']
liborc-tools.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/orc/generate_xml_table ['/usr/lib64']
liborc-tools.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/orc/test_accsadubl ['/usr/lib64']
liborc-tools.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/orc/exec_opcodes_pixel ['/usr/lib64']
liborc-tools.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/orcc
['/usr/lib64']
liborc-tools.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/orc/compile_opcodes_float_c ['/usr/lib64']
liborc-tools.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/orc/compile_opcodes_pixel_c ['/usr/lib64']
liborc-tools.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/orc/mt19937ar
['/usr/lib64']
liborc-tools.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/orc/compile_opcodes_sys ['/usr/lib64']
liborc-tools.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/orc/compile_opcodes_pixel ['/usr/lib64']
liborc-tools.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/orc/exec_opcodes_sys ['/usr/lib64']
5 packages and 0 specfiles checked; 21 errors, 0 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.