[Bug 522988] Review Request: afraid-dyndns - A dynamic DNS client for the free service afraid.org

bugzilla at redhat.com bugzilla at redhat.com
Sat Oct 3 18:52:32 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=522988





--- Comment #37 from Erick Calder <e at arix.com>  2009-10-03 14:52:31 EDT ---
> You shouldn't do that, because when importing whole srpms all the time, you
> effectively have no version control of the changes you did to the spec. I mean,
> how would you compare the changes? When you are working in the local checkout
> of the cvs, you can easily check the changes with cvs diff -u before you commit
> them.

hmm... I think in this case it's a little different because I'm the developer
so I've included the spec file in the tarball (and it lives with my source
code, under SVN)

but I do see your issue.  I'm also navigating mod_gnutls (for which I'm not the
developer) through this process so my spec file isn't revisioned as it just
sits in ~rpm/SPECS

I read through your link above but it does not talk about how to keep your spec
(and possibly, patch files) in cvs... do you have a reference for that?

> > what is the value of this tag?
> 
> Every package must have a corresponding tag. You can checkout cvs by that
> particular tag and will get exactly the state that the package was built from.  

ok, I've decided to roll back the changes to the Makefile.  the better solution
is to create a patch file specific for F10.  so now the only thing is I don't
know how to apply a patch file conditionally i.e. for F10 only.  can you help
with that?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list