[Bug 527059] Review Request: earcandy - Sound level manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=527059





--- Comment #4 from Lubomir Rintel <lkundrak at v3.sk>  2009-10-05 04:40:28 EDT ---
(In reply to comment #2)
> A couple of comments:

Thanks for them!

> - the file pulseaudio/lib.py is licensed under BSD

Fixed.

> - you should replace the shebang of file ear_candy according to
> https://fedoraproject.org/wiki/Script_Interpreters_%28draft%29

Fixed.

> Even if the shebangs don't hurt, I would remove them anyway, e.g. with 

Done

> After doing so, there's still a remaining error. It can be ignored because
> package pulseaudio-libs is not picked up automatically.

I do not think so; even if we dlopen libpulse, we still do assumptions about
ABI, therefore I changed this to depend on specific ABI version and the rpmlint
warning went away.

SPEC: http://v3.sk/~lkundrak/SPECS/earcandy.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/earcandy-0.5.1-2.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.