[Bug 502614] Review Request: stfl - STFL implements a curses-based widget set for text terminals

bugzilla at redhat.com bugzilla at redhat.com
Tue Oct 6 07:44:59 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502614





--- Comment #34 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-10-06 03:44:58 EDT ---
Use a patch instead of sed, since sed will quietly do nothing if the makefile
changes in the future, whereas patch will fail and let you know.

**

I'd say you have to modify the default CFLAGS:
 export CFLAGS += -I. -Wall -Os -ggdb -D_GNU_SOURCE -fPIC
You were probably failing due to the missing -I. -D_GNU_SOURCE which modifies
compilation behaviour when you tried
 export CFLAGS += $(RPM_OPT_FLAGS)
Just replace this occurrence with
 export CFLAGS += -I. -D_GNU_SOURCE -fPIC
You need to do this, since -Os will override the default Fedora optimization
flag (-O2).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list